From kde-core-devel Mon Oct 01 17:15:41 2007 From: "Joris Guisson" Date: Mon, 01 Oct 2007 17:15:41 +0000 To: kde-core-devel Subject: Re: [PATCH/RFC] KMultiTabBar surgery... Message-Id: <6bc528f40710011015w39a49073ldcd78546c603263e () mail ! gmail ! com> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119125910226583 MIME-Version: 1 Content-Type: multipart/mixed; boundary="------=_Part_8046_9196273.1191258941334" ------=_Part_8046_9196273.1191258941334 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline OK, patch is fine for me, I must say it looks a lot better then before with oxygen as style. Joris, On 10/1/07, Joris Guisson wrote: > > Seeing that KTorrent also uses KMultiTabBar, I would like to test this > before you commit. I will do this, this evening when I get back from work= . > Don't know how late that is in your timezone, but I believe the US is 6 > hours or more behind Europe, so you should have an answer in time. > > I hope this patch solves the rendering issues with oxygen, because a > selected tab is rendered very ugly with oxygen. > > Joris, > > On 10/1/07, Christoph Cullmann wrote: > > > > On Monday 01 October 2007 06:12, Maksim Orlovich wrote: > > > Hi... When looking at fixing major problems in painting of konq's > > sidebar > > > in trunk (#148192, perhaps others), I quickly diagnosed it to > > KMultiTabBar > > > widget in kdeui, which is also used in Kate. Unfortunately, it's > > currently > > > in a rather bad state --- it has tons of methods that don't do > > anything, > > > unused modes that do weird things, etc. Worse, its basic operation > > mode is > > > to hard code width to 24 pixels. This of course is very wrong since > > > accessibility may require a larger font (plus it has its own, > > > ultra-complex layout code). In short, the attached removes most of > > these > > > things. Most of the interesting work now is done by Qt layouts, and > > the > > > toggle-tab widgets provide appropriate size hint and painting. One > > cost of > > > this change is that when widgets do not fit, it no longer goes into a > > > multi-line mode --- but it can squeeze the label text instead. In my > > > experience it worked well for kate w/all the plugins I have enabled. > > API > > > changes are just removing redundancy, unused methods of dubious value= s > > and > > > methods that did not do anything. Porting patches attached. > > > > > > Anyway, I will commit this monday night EST if no one has a big issue > > with > > > it -- but I'd welcome feedback, especially from the Kate folks in cas= e > > the > > > details aren't quite to their taste. > > I am all for it :=3D) KMultiTabBar is the "worst" part of the Kate UI, = I > > mostly > > chosen it, as it allows multiple tabs to be selected at once, which is > > needed. I doubt Kate uses the "multiple rows of text" wrapping and any > > improvement is welcome to rendering. I have not tested the patches for > > the > > look'n'feel, but if you say it looks well, I trust you. (given the > > current > > state, I doubt there can be any worse look possible...) > > > > cu > > Christoph > > > > -- > > -------------------------------------- Christoph Cullmann --------- > > AbsInt Angewandte Informatik GmbH Email: cullmann@AbsInt.com > > Science Park 1 Tel: +49-681-38360-22 > > 66123 Saarbr=FCcken Fax: +49-681-38360-20 > > GERMANY WWW: http://www.AbsInt.com > > -------------------------------------------------------------------- > > Gesch=E4ftsf=FChrung: Dr.-Ing. Christian Ferdinand > > Eingetragen im Handelsregister des Amtsgerichts Saarbr=FCcken, HRB 1123= 4 > > > > ------=_Part_8046_9196273.1191258941334 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline OK, patch is fine for me, I must say it looks a lot better then before with= oxygen as style.

Joris,

On = 10/1/07, Joris Guisson < joris.guisson@gmail.com> wrote:
Seeing that KTorrent also uses KMultiTabBar, I = would like to test this before you commit. I will do this, this evening whe= n I get back from work. Don't know how late that is in your timezone, b= ut I believe the US is 6 hours or more behind Europe, so you should have an= answer in time.

I hope this patch solves the rendering issues with oxygen, because = a selected tab is rendered very ugly with oxygen.
Joris,


On 10/1/07, Chris= toph Cullmann <cullmann@absint.com&g= t; wrote:
On Monday 01 October 2007 06:12, Maksim Orlovich wrote:
> Hi... When looking at fixing major problems in painting of konq= 9;s sidebar
> in trunk (#148192, perhaps others), I quickly diagnosed= it to KMultiTabBar
> widget in kdeui, which is also used in Kate. Un= fortunately, it's currently
> in a rather bad state --- it has tons of methods that don't do= anything,
> unused modes that do weird things, etc. Worse, its basic= operation mode is
> to hard code width to 24 pixels. This of course = is very wrong since
> accessibility may require a larger font (plus it has its own,
&= gt; ultra-complex layout code). In short, the attached removes most of thes= e
> things. Most of the interesting work now is done by Qt layouts, a= nd the
> toggle-tab widgets provide appropriate size hint and painting. One= cost of
> this change is that when widgets do not fit, it no longer = goes into a
> multi-line mode --- but it can squeeze the label text i= nstead. In my
> experience it worked well for kate w/all the plugins I have enable= d. API
> changes are just removing redundancy, unused methods of dubi= ous values and
> methods that did not do anything. Porting patches at= tached.
>
> Anyway, I will commit this monday night EST if no one has = a big issue with
> it -- but I'd welcome feedback, especially fro= m the Kate folks in case the
> details aren't quite to their tast= e.
I am all for it :=3D) KMultiTabBar is the "worst" part of the= Kate UI, I mostly
chosen it, as it allows multiple tabs to be selected = at once, which is
needed. I doubt Kate uses the "multiple rows of t= ext" wrapping and any
improvement is welcome to rendering. I have not tested the patches for = the
look'n'feel, but if you say it looks well, I trust you. (giv= en the current
state, I doubt there can be any worse look possible...)

cu
Christoph

--
--------------------------------------= Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH &nb= sp;    Email: cullmann@AbsInt.com
Science Park 1     &nbs= p;            &= nbsp;      Tel:   +49-681-38360-22
66123 Saarbr=FCcken        &nbs= p;            &= nbsp;Fax:   +49-681-38360-20
GERMANY    &n= bsp;            = ;            &n= bsp;  WWW:   http:/= /www.AbsInt.com
-------------------------------------------------------------------= -
Gesch=E4ftsf=FChrung: Dr.-Ing. Christian Ferdinand
Eingetragen im Ha= ndelsregister des Amtsgerichts Saarbr=FCcken, HRB 11234


------=_Part_8046_9196273.1191258941334--