[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    AW: API change request
From:       "Nhuh Put" <nhuh.put () web ! de>
Date:       2007-09-03 23:35:13
Message-ID: 012801c7ee83$142b0a80$3301a8c0 () spika
[Download RAW message or body]

> Von: Allen Winter
> Gesendet: Dienstag, 4. September 2007 01:13
> An: kde-core-devel@kde.org
> Betreff: Re: API change request
> 
> On Saturday 01 September 2007 11:42:30 am Alex Merry wrote:
> > I'd like to change the KScanDialog and KOCRScanDialog constructors to
> > take two more arguments, in line with KPluginFactory.  This means that
> > those values can then be passed to the KPluginFactory constructors.
> >
> > Attached is the diff for kdelibs/kio/kio/kscan.{h,cpp}
> >
> > This is needed to make libkscan (the implementation of KScanDialog,
> > contained in kdegraphics) a proper new-style plugin.  I'll obviously
> > patch libkscan at the same time.
> >
> > LXR shows that only libkscan is using KScanDialogFactory (and libkscan
> > currently doesn't work, but I can make it at least load with this
> > change).
> >
> > I'll commit on Monday if no-one objects.
> >
> Was this completed today?

KScanDialogFactory can disappear completly, all the necessary stuff is
already in KPluginFactory. I would port libkscan and remove the factory
class nex Monday.

	PutHuhn

[prev in list] [next in list] [prev in thread] [next in thread]