[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: API change request
From:       Allen Winter <winter () kde ! org>
Date:       2007-09-03 23:13:07
Message-ID: 200709031913.07459.winter () kde ! org
[Download RAW message or body]

On Saturday 01 September 2007 11:42:30 am Alex Merry wrote:
> I'd like to change the KScanDialog and KOCRScanDialog constructors to 
> take two more arguments, in line with KPluginFactory.  This means that 
> those values can then be passed to the KPluginFactory constructors.
> 
> Attached is the diff for kdelibs/kio/kio/kscan.{h,cpp}
> 
> This is needed to make libkscan (the implementation of KScanDialog, 
> contained in kdegraphics) a proper new-style plugin.  I'll obviously 
> patch libkscan at the same time.
> 
> LXR shows that only libkscan is using KScanDialogFactory (and libkscan 
> currently doesn't work, but I can make it at least load with this 
> change).
> 
> I'll commit on Monday if no-one objects.
> 
Was this completed today?
[prev in list] [next in list] [prev in thread] [next in thread]