[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: EBN Fixes
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2007-07-13 18:55:27
Message-ID: 1aa4e8880707131155m7821490ci7e61463f13cd5488 () mail ! gmail ! com
[Download RAW message or body]

i realised that just after sending it, so sent a patch without the
stupid ones in. sorry about that. the second patch should be OK though

On 7/13/07, Maksim Orlovich <mo85@cornell.edu> wrote:
> > Just a couple of really basic EBN fixes to khtml which I did whilst
> > waiting for something to compile :). Assuming they're OK, could
> > someone please commit them since I don't have an svn account.
>
> -  return "[object " + className() + "]";
> +  return "[object " + className() + ']';
>
> How does this even compile? UString only has an operator+ working on
> UStrings, and the single-char ctor for it is explicit.
>
> Ditto for:
>      if (id == HTMLDocument::WriteLn)
> -      str += "\n";
> +      str += '\n';
>
> .. and a bunch of other locations.
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]