[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: EBN Fixes
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2007-07-13 18:47:44
Message-ID: 13754.24.59.192.15.1184352464.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

> Just a couple of really basic EBN fixes to khtml which I did whilst
> waiting for something to compile :). Assuming they're OK, could
> someone please commit them since I don't have an svn account.

-  return "[object " + className() + "]";
+  return "[object " + className() + ']';

How does this even compile? UString only has an operator+ working on
UStrings, and the single-char ctor for it is explicit.

Ditto for:
     if (id == HTMLDocument::WriteLn)
-      str += "\n";
+      str += '\n';

.. and a bunch of other locations.


[prev in list] [next in list] [prev in thread] [next in thread]