[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: RFC: KInputDialog + completion
From:       Nadeem Hasan <nhasan () nadmm ! com>
Date:       2007-03-05 2:47:14
Message-ID: 200703042147.20235.nhasan () nadmm ! com
[Download RAW message or body]


On Sunday 04 March 2007 09:09:45 am Joseph Wenninger wrote:
> Hi !
>
> I'd like to propose an API change of the static getText member function of
> the KInputDialog class.
>
> I propose to add an additional string list parameter at the end, which
> allows to specify items for input completion of the line edit.
>
> Attached is a patch which contains the needed changes and modifications for
> the test applications

Looks good to me with one reservation: Please follow whitespace policy of the 
file.

Regards
-- 
Nadeem Hasan (nhasan-at-nadmm.com)
GPG Fingerprint: 7141 0B1C 9CAF 624D 307F F8EF 6C0C 753E DD3A 0F53

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]