From kde-core-devel Mon Mar 05 02:47:14 2007 From: Nadeem Hasan Date: Mon, 05 Mar 2007 02:47:14 +0000 To: kde-core-devel Subject: Re: RFC: KInputDialog + completion Message-Id: <200703042147.20235.nhasan () nadmm ! com> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=117306249006335 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart10384634.6XkVtPYqyp" --nextPart10384634.6XkVtPYqyp Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 04 March 2007 09:09:45 am Joseph Wenninger wrote: > Hi ! > > I'd like to propose an API change of the static getText member function of > the KInputDialog class. > > I propose to add an additional string list parameter at the end, which > allows to specify items for input completion of the line edit. > > Attached is a patch which contains the needed changes and modifications f= or > the test applications Looks good to me with one reservation: Please follow whitespace policy of t= he=20 file. Regards =2D-=20 Nadeem Hasan (nhasan-at-nadmm.com) GPG Fingerprint: 7141 0B1C 9CAF 624D 307F F8EF 6C0C 753E DD3A 0F53 --nextPart10384634.6XkVtPYqyp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF64S4bAx1Pt06D1MRAsWKAJ9AOWIwgxH2RSq5ykVUmJa7+tKwcwCcDh40 8GtuWZfe1WM2kIeOCaXtmJ4= =AqJH -----END PGP SIGNATURE----- --nextPart10384634.6XkVtPYqyp--