[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: secondary window titles
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2006-11-13 17:56:54
Message-ID: 200611131056.55425.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Monday 13 November 2006 10:02, Benjamin Meyer wrote:
> On Monday 13 November 2006 17:18, Aaron J. Seigo wrote:
> > On Monday 13 November 2006 6:44, Benjamin Meyer wrote:
> > > I would like to propose that in KDE 4 our secondary windows wont
> > > automatically append the application name.  This will make us
> > > consistant with the other desktop enviornments.
> >
> > other than consistency what are the benefits?
>
> Perhaps we might not have to subclass some dialogs from Qt just to set the
> caption,

which dialogs are these? (serious question)

> but consistency is the biggest reason especially sense we want to 
> start launching our applications in OS X and windows.

if it's a usability improvement, i don't see why we would do this.

if this is a violation of interface guidelines on these platforms, a solution 
IMHO would be add alternate, platform-specific code paths to 
KInstance::makeStdCaption(...). example patch is attached, even ;)

if the KDE4 HIG alters our guidelines in this regard, then we can change the 
code appropriately then. 

> > a negative side effect of this change would be not knowing what
> > application a file dialog applies to by just looking at it.
>
> Have you ever had that problem? 

yes. it's a retention-of-context issue.

this is exacerbated by the fact that we have virtual desktops, allowing one to 
move one of these dialogs to another desktop.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)

["no_app_captions_on_mac_win.diff" (text/x-diff)]

Index: kinstance.cpp
===================================================================
--- kinstance.cpp	(revision 604657)
+++ kinstance.cpp	(working copy)
@@ -310,12 +310,16 @@
   if (flags & ModifiedCaption)
       captionString += QString::fromUtf8(" [") + i18n("modified") + QString::fromUtf8("]");
 
+#ifndef Q_WS_WIN
+#ifndef Q_WS_MAC
   if ( !userCaption.isEmpty() ) {
       // Add the application name if:
       // User asked for it, it's not a duplication  and the app name (caption()) is not empty
       if ( flags & AppNameCaption && !caption().isNull() && !userCaption.endsWith(caption())  )
 	  captionString += QString::fromUtf8(" - ") + caption();
   }
+#endif
+#endif
 
   return captionString;
 }

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]