[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Introducing LikeBack - Quick Feedback from Beta-Testers
From:       Adriaan de Groot <groot () kde ! org>
Date:       2006-08-13 22:22:25
Message-ID: 200608140022.25819.groot () kde ! org
[Download RAW message or body]

On Sunday 13 August 2006 23:05, Sébastien Laoût wrote:
> Note: The test "Check for adding single char string to a QString..." also
> search in comments! It referenced that line (and others) as an error:
>
> 	//QString namedMailExpString = "[.]*[ \\t]+<" + mailExpString + ">";
>
> This is a good thing here, because it's effectively a code that can be
> uncommented, but is it wanted to check in comments?

Yes. Since comments can also be *suggested* code or hints to other developers, 
we (as in the EBN guys) decided that comments should be correct code as well.

> Oh, and it complained about licence has a wrong address but does not tell
> me what is the address I should have added.

That's a reasonable addition, but as Jaison points out then we'd need to 
fine-tune the warning for whatever licenses there are -- and it links to 
sample text anyway.

> Who should I contact to propose those "dislike" comments about EBN ? ;-)

Jaison, Allen, myself, or #ebn on irc.kde.org

-- 
KDE Quality Team
GPG: FEA2 A3FE

[prev in list] [next in list] [prev in thread] [next in thread]