[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Standalone qt-dbus in kdesupport
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2006-06-08 19:17:06
Message-ID: 200606082117.06907.neundorf () kde ! org
[Download RAW message or body]

Hi,

On Thursday 08 June 2006 20:45, Paulo Jorge Guedes wrote:
...
> ===================================================================
> --- CMakeLists.txt    (revision 549165)
> +++ CMakeLists.txt    (working copy)
> @@ -1 +1,7 @@
> +PROJECT(kdesupport)
> +
> +if(WIN32)
> +   ADD_SUBDIRECTORY( kdewin32 )
> +endif(WIN32)
> +
>  ADD_SUBDIRECTORY( qt-dbus )

This looks good.


> ===================================================================
>
> FindKDEWIN32.cmake should also be changed. Perhaps it could use the same
> approach of FindQtDBus on Windows, and first try to find a KDEWIN32_DIR
> (like the QDBUS_DIR).

Both need some work. 
Instead of 
find_file(QDBUS_IDL2CPP_EXECUTABLE dbusidl2cpp.exe ...)
find_program(QDBUS_IDL2CPP_EXECUTABLE NAMES dbusidl2cpp PATHS ...)
should be used.
But I don't understand why QtDBUS should look for kdesupport.

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net
[prev in list] [next in list] [prev in thread] [next in thread]