[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    RE: Standalone qt-dbus in kdesupport
From:       Paulo Jorge Guedes <Paulo.Guedes () artelecom ! pt>
Date:       2006-06-08 18:45:27
Message-ID: 638DECE198A2DC4BB66AC74BD51097CC07D4F8 () SRVEXC02 ! corp ! artelecom ! pt
[Download RAW message or body]

> -----Original Message-----
> From: Paulo Jorge Guedes [mailto:Paulo.Guedes@artelecom.pt]
> Sent: quinta-feira, 8 de Junho de 2006 19:31
> To: kde-core-devel@kde.org
> Subject: RE: Standalone qt-dbus in kdesupport
> 
> > > > > >So, what do you think of
> > > > > >
> > > > > >--- CMakeLists.txt    (revision 549165)
> > > > > >+++ CMakeLists.txt    (working copy)
> > > > > >@@ -1 +0,0 @@
> > > > > >-ADD_SUBDIRECTORY( qt-dbus )
> > > > >
> > > > > Huh? Why do you want to disable qt-dbus builds?
> > > >
> > > > No he wants people to run cmake from within qt-dbus instead of
> doing
> > > it
> > > > for the whole of kdesupport in one go.
> > > >
> > > > As long as kdesvn-build supports it, I don't mind too much
> > > > (right now I install kdesupport into its own prefix, which is a
> bit
> > > > strange
> > > > since it's a collection of unrelated things).
> > >
> > > Precisely.
> > > People can always do cmake ..\kdesupport\qt-dbus in some qt-dbus
> build
> > > directory but IMHO it would be better if they were forced to (just
> like
> > > people build kdewin32) because, like David said, it's a collection
> of
> > > unrelated things.
> >
> > But if both are possible in the current situation, then I don't see
> the
> > point in forcing
> > anything upon people...
> 
> Then perhaps we should change FindQtDbus.cmake, because it won't find
> nothing on windows if one does make install on kdesupport.

Something like this:

===================================================================
--- FindQtDBus.cmake    (revision 549359) 
+++ FindQtDBus.cmake    (working copy) 
@@ -28,7 +28,7 @@
 else (QDBUS_INCLUDE_DIRS AND QDBUS_LIBRARIES)
 
    if (WIN32)
-       find_file(QDBUS_DIR qt-dbus 
+       find_file(QDBUS_DIR kdesupport 
           ${_progFiles}
           "C:/"
        )

===================================================================
--- CMakeLists.txt    (revision 549165) 
+++ CMakeLists.txt    (working copy) 
@@ -1 +1,7 @@
+PROJECT(kdesupport) 
+ 
+if(WIN32) 
+   ADD_SUBDIRECTORY( kdewin32 ) 
+endif(WIN32) 
+ 
 ADD_SUBDIRECTORY( qt-dbus )

===================================================================

FindKDEWIN32.cmake should also be changed. Perhaps it could use the same
approach of FindQtDBus on Windows, and first try to find a KDEWIN32_DIR
(like the QDBUS_DIR).

This would make more sense. As it is right now, it's just not coherent.
If you find this sensitive, I can present a complete patch.

Paulo 
[prev in list] [next in list] [prev in thread] [next in thread]