[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: CMake Questions
From:       Adriaan de Groot <groot () kde ! org>
Date:       2006-03-18 22:49:52
Message-ID: 200603182349.57278.groot () kde ! org
[Download RAW message or body]


On Saturday 18 March 2006 23:07, Allen Winter wrote:
> I just committed a change which provides

> --enable-final            
>   -DCMAKE_BUILD_TYPE=release          -O2

Are you sure about that one? --enable-final does some very *different* things 
than just setting optimization flags, and is generally broken and unsupported 
(ie. there's nothing like a "policy" that says things should compile with 
--enable-final, and it's generally easier to add NO_FINAL to a directory than 
to figure out what's wrong). So you might want to change the mapping; the 
cmake option isn't bad.

In addition, can you add this to COMPILING-WITH-CMAKE in kdelibs/ and/or to 
the hypothetical compilation instructions on developer.kde.org ?

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]