[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [Patch] More on KDialog
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2006-01-02 12:30:36
Message-ID: 200601021330.41040.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Hi,

After all the discussion, here is a new patch.
It let the KJanusWidget in KDialogBase.

So buttons handling, size handling, and some common stuff are moved to 
KDialog.
And one can add easily a single widget with KDialog::setMainWidget  (the 
common case IMO)

If one want one of the possibility that KJanusWidget offer, KDialogBase is 
still required
(maybe it should be renamed to KJanusDialog)

So if people want to implement stuff based on QAbstractModel , this could be 
done in a dialog that inherit KDialog

Anyway, KDialogBase (KJanusDialog) is not really usefull since it is easy to 
do

KDialog *dialog= new KDialog( this  , "caption");
KJanusWidget *janus=new KJanusWidget( dialog , ... )
dialog->setMainWidget(janus);
janus->addPage( .... )  // like if janus is the KDialogBase

(this is what do KDialogBase internaly in that patch)


Ok to commit ?
(it need still to be polished, but i'd like to commit to not resolve conflict 
everyday)

--
Olivier

["kdialog.tar.gz" (application/x-tgz)]
[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]