[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] add dummy operator== and dummy qHash for win32 target
From:       Thiago Macieira <thiago () kde ! org>
Date:       2005-11-06 13:19:00
Message-ID: 200511061119.01869.thiago () kde ! org
[Download RAW message or body]


Christian Ehrlicher wrote:
>Thiago Macieira schrieb:
>> Christian Ehrlicher wrote:
>>>I've now put a '#ifdef MAKE_KDECORE_LIB' around to avoid using it
>>>outside the lib.
>>
>> I am Ok with this patch (at least the parts that touch my code).
>>
>> I couldn't understand the relevance of adding s to KeyboardModifier
>> :-)
>
>Because 'Qt::KeyboardModifiers QKeyEvent::modifiers () const' -> see
>also qnamespace.h: Q_DECLARE_FLAGS(KeyboardModifiers, KeyboardModifier)
>
>Is anyone there who can check in my patches?

I did, and I said they are ok.

But your patch contained changes that were completely unrelated (that 
KeyboardModifier stuff).

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]