From kde-core-devel  Sun Nov 06 13:19:00 2005
From: Thiago Macieira <thiago () kde ! org>
Date: Sun, 06 Nov 2005 13:19:00 +0000
To: kde-core-devel
Subject: Re: [PATCH] add dummy operator== and dummy qHash for win32 target
Message-Id: <200511061119.01869.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=113128315502384
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1503793.dQpygqO3cu"

--nextPart1503793.dQpygqO3cu
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Christian Ehrlicher wrote:
>Thiago Macieira schrieb:
>> Christian Ehrlicher wrote:
>>>I've now put a '#ifdef MAKE_KDECORE_LIB' around to avoid using it
>>>outside the lib.
>>
>> I am Ok with this patch (at least the parts that touch my code).
>>
>> I couldn't understand the relevance of adding s to KeyboardModifier
>> :-)
>
>Because 'Qt::KeyboardModifiers QKeyEvent::modifiers () const' -> see
>also qnamespace.h: Q_DECLARE_FLAGS(KeyboardModifiers, KeyboardModifier)
>
>Is anyone there who can check in my patches?

I did, and I said they are ok.

But your patch contained changes that were completely unrelated (that=20
KeyboardModifier stuff).

=2D-=20
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t w=E6s n=E1ht, se scieppend =FEone circolwyr=
de=20
wundorcr=E6ftl=EDge cennede and seo eor=F0e w=E6s idel and hit w=E6s g=F3d.

--nextPart1503793.dQpygqO3cu
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQBDbgLFM/XwBW70U1gRAt69AJ9/F+FlELTFfXd4gnEpdYf5Tc5OsgCbBUDr
l6hg6wNEP2he7+VPYpLdbWc=
=Uq8X
-----END PGP SIGNATURE-----

--nextPart1503793.dQpygqO3cu--