[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [Patch] fix compile kdecore with msvc
From: Thiago Macieira <thiago () kde ! org>
Date: 2005-10-29 20:26:34
Message-ID: 200510291826.46021.thiago () kde ! org
[Download RAW message or body]
Christian Ehrlicher wrote:
>Changes:
>network/kresolver.cpp
>- masked '#warning' - is gnuc-specific
ok
>network/kresolver.h
>- don't export KResolverResults to avoid compiler errors (*)
Not acceptable. Don't commit this.
>network/ksocketdevice.cpp
>- don't include ksockssocketdevice in windows to avoid linker errors
Understandable. I want to fix that later by other means.
>- indentation fixes (tabulator -> spaces)
Superfluous.
>- add kde_ioctl because ioctl isn't available in windows
>network/syssocket.h
>- add kde_ioctl (**)
Ok, makes sense.
>* there is imho no need to export KResolverResults because nobody
>derivates a class from KResolverResults. And if you really want to
>export this class, you have to implement all functions QList<T> defines
>because otherwise when someone wants to use a function you forgot to
>implement he will get a linker error.
Your argument doesn't make sense. Functions that were not overridden will
be inherited from QList<T>.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
4. And æfter se scieppend ingelogode, he wrát "cenn", ac eala! se
rihtendgesamnung andswarode "cenn: ne wát hú cennan 'eall'. Ástynt."
[Attachment #3 (application/pgp-signature)]
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic