From kde-core-devel  Sat Oct 29 20:26:34 2005
From: Thiago Macieira <thiago () kde ! org>
Date: Sat, 29 Oct 2005 20:26:34 +0000
To: kde-core-devel
Subject: Re: [Patch] fix compile kdecore with msvc
Message-Id: <200510291826.46021.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=113061761723242
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1149967.BoWIvsaOuA"

--nextPart1149967.BoWIvsaOuA
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Christian Ehrlicher wrote:
>Changes:
>network/kresolver.cpp
>- masked '#warning' - is gnuc-specific

ok

>network/kresolver.h
>- don't export KResolverResults to avoid compiler errors (*)

Not acceptable. Don't commit this.

>network/ksocketdevice.cpp
>- don't include ksockssocketdevice in windows to avoid linker errors

Understandable. I want to fix that later by other means.

>- indentation fixes (tabulator -> spaces)

Superfluous.

>- add kde_ioctl because ioctl isn't available in windows
>network/syssocket.h
>- add kde_ioctl (**)

Ok, makes sense.

>* there is imho no need to export KResolverResults because nobody
>derivates a class from KResolverResults. And if you really want to
>export this class, you have to implement all functions QList<T> defines
>because otherwise when someone wants to use a function you forgot to
>implement he will get a linker error.

Your argument doesn't make sense. Functions that were not overridden will=20
be inherited from QList<T>.

=2D-=20
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

4. And =E6fter se scieppend ingelogode, he wr=E1t "cenn", ac eala! se=20
rihtendgesamnung andswarode "cenn: ne w=E1t h=FA cennan 'eall'. =C1stynt."

--nextPart1149967.BoWIvsaOuA
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQBDY9sFM/XwBW70U1gRAtznAJwKf97q6rz45SD4R9DS9QncCsQWRQCcCOvi
kXgkDhxcM0SpFhpiZhyF/r8=
=rwXz
-----END PGP SIGNATURE-----

--nextPart1149967.BoWIvsaOuA--