[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    bugfixlet.
From:       Thomas Zander <zander () kde ! org>
Date:       2005-03-30 18:15:15
Message-ID: 200503302015.33900.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Ok, its been ages since I fixed anything in kdecore so when I found this 
silly bug I figured I'd post a patch first..
Bug; (found in branch)
open kwrite, open the 'configure shortcuts' dialog from the settings menu.
Select an action hat has both a shortcut and an alternate. Click the button 
to configure that one.
Clear the primary shortcut using the 'clear' button.
Press OK.
You will get a warning saying that the '' (aka empty) keyboard shortcut is 
also in use in the global keyboard settings!

Please comment on attached patch.

please cc answers.
-- 
Thomas Zander

[Attachment #5 (application/pgp-signature)]
["kkeydialog.diff" (text/x-diff)]

Index: kdeui/kkeydialog.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kkeydialog.cpp,v
retrieving revision 1.168
diff -u -3 -p -r1.168 kkeydialog.cpp
--- kdeui/kkeydialog.cpp	18 Feb 2005 00:33:21 -0000	1.168
+++ kdeui/kkeydialog.cpp	30 Mar 2005 18:00:40 -0000
@@ -948,6 +948,8 @@ void KKeyChooser::_warning( const KKeySe
 
 bool KKeyChooser::promptForReassign( const KKeySequence& cut, const QString& \
sAction, ActionType type, QWidget* parent )  {
+        if(cut.isNull())
+            return true;
         QString sTitle;
         QString s;
         if( type == Standard ) {



[prev in list] [next in list] [prev in thread] [next in thread]