[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KSaveFile::abort() on win32
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-03-30 16:29:28
Message-ID: 200503301829.32194.bastian () kde ! org
[Download RAW message or body]


On Wednesday 30 March 2005 17:30, Oswald Buddenhagen wrote:
> On Wed, Mar 30, 2005 at 04:58:10PM +0100, Jaroslaw Staniek wrote:
> > +++ ksavefile.cpp	30 Mar 2005 14:53:05 -0000
> > @@ -99,8 +99,17 @@
> >  void
> >  KSaveFile::abort()
> >  {
> > +#ifdef Q_WS_WIN
> > +   //for win32: close before unlinking
> > +   QString tmpName( mTempFile.name() );
> > +#else
> >     mTempFile.unlink();
> > +#endif
> >     mTempFile.close();
> > +#ifdef Q_WS_WIN
> > +   if (!tmpName.isEmpty())
> > +      QFile::remove( tmpName );
> > +#endif
> >  }
>
> i think in this case the order is not relevant, so just close it before
> unlinking unconditionally, i'd say. waldo?

I agree.

Cheers,
Waldo

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]