[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs 3.4.0 BICs -- KIO::Job, KNS::DownloadDialog, KNS::Engine,
From:       David Faure <faure () kde ! org>
Date:       2005-02-27 18:41:13
Message-ID: 200502271941.14834.faure () kde ! org
[Download RAW message or body]

On Sunday 27 February 2005 17:50, Maks Orlovich wrote:
> Hi.. I've been playing a bit with make bcheck, and it spotted some binary 
> incompatibilities.
> 
> The first one is in KIO::Job. There is a new virtual:
> 	virtual void removeSubjob( Job *job, bool mergeMetaData, 
> 			bool emitResultIfLast ); 

Ooops it shouldn't have been virtual !!!
It was supposed to just be an overload of the other one, it's not reimplemented anywhere.

Stephan: do we still have time to fix that? (simply remove the virtual in front of that one).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]