[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs 3.4.0 BICs -- KIO::Job, KNS::DownloadDialog, KNS::Engine,
From:       Andras Mantia <amantia () kde ! org>
Date:       2005-02-27 18:17:52
Message-ID: 200502272017.52255.amantia () kde ! org
[Download RAW message or body]


On Sunday 27 February 2005 20:09, Maks Orlovich wrote:
> On Sunday 27 February 2005 12:25, you wrote:
> > Am Sonntag, 27. Februar 2005 17:50 schrieb Maks Orlovich:
> > > KNS::DownloadDialog is incompatible due to a size change: there
> > > is an extra field, QString m_providerlist;
> > >
> > > Similarly, KNS::Engine adds in  bool mIgnoreInstallResult;
> >
> > In both cases it should be possible to mark the new members as
> > static. Can this be confirmed?
>
> That would fix the BC bug, yes; but is there any risk of multiple
> instances of the object?

Yes, I think it usually can be two Engine instances in the memory. But 
usually and in normal case every instance would have this flag set to 
the same value. 

> An alternative is something like this: 

If this is BC (and looks like so, nice trick!), I'd vote for it.

> Oh, and *bug*: mIgnoreInstallResult doesn't seem to be initialized in
> the constructor.

Oops. 

Andras

-- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]