[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] win32 paths-related fixes
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-02-11 23:56:54
Message-ID: 200502120056.58612.bastian () kde ! org
[Download RAW message or body]


On Friday 11 February 2005 23:16, Jaroslaw Staniek wrote:
> Good idea, and what about:
>
>     if ( !KURL::isRelativeURL( QString::fromLocal8Bit(urlArg) ) )
>       return KURL(QString::fromLocal8Bit(urlArg)); // Argument is a URL
>
> in KCmdLineArgs::makeURL()? -- is QString::fromLocal8Bit(urlArg) needed or
> replacing it with _urlArg is enough?

I think it can be replaced, please include the following comment in the commit 
log if you replace it:

"Use QFile::decodeName instead of QString::fromLocal8Bit. 
QString::fromLocal8Bit only differs from QFile::decodeName() if 
$KDE_UTF8_FILENAMES is set, and in that case it is really hard to tell which 
of the two should be used. KProcess uses QFile::decodeName to encode command 
line arguments, so we better use that for decoding as well. This issue will 
become even less relevant over time since utf8 is becoming more popular as 
locale in which case setting $KDE_UTF8_FILENAMES makes no difference anyway."

Cheers,
Waldo
-- 
bastian@kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian@suse.com  |   http://www.novell.com/products/desktop/eval.html

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]