[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] win32 paths-related fixes
From:       Thiago Macieira <thiago.macieira () kdemail ! net>
Date:       2005-02-11 23:23:16
Message-ID: 200502112123.16924.thiago.macieira () kdemail ! net
[Download RAW message or body]


Jaroslaw Staniek wrote:
>    if ( !KURL::isRelativeURL( QString::fromLocal8Bit(urlArg) ) )

No. The filename encoding doesn't have to be the local 8-bit encoding.

IMO it's more trouble than it's worth to do so, but it's a valid case 
nonetheless.

Use QFile::decodeName() and QFile::encodeName().

>      return KURL(QString::fromLocal8Bit(urlArg)); // Argument is a URL
>
>in KCmdLineArgs::makeURL()? -- is QString::fromLocal8Bit(urlArg) needed
> or replacing it with _urlArg is enough?
-- 
  Thiago Macieira  -  thiago (AT) macieira (DOT) info
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic