[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KToogleAction not working?
From:       "Stefan Nikolaus" <stefan.nikolaus () stuco ! uni-oldenburg ! de>
Date:       2005-01-03 17:39:22
Message-ID: opsj1fbwxkpowx5f () stahl ! stuco ! uni-oldenburg ! de
[Download RAW message or body]

Am Mon, 3 Jan 2005 16:04:22 +0100 hat Enrico Ros <eros.kde@email.it>  
geschrieben:
> On Monday 03 January 2005 14:12, Stefan Nikolaus wrote:
>> I have no write access. Could anyone else do it for me?
>
> Done. Thank you again! It was a bad regression.

Well, two lines moved and broken the whole new feature. That's sounds like  
me. Obviously the buttonClicked() signal has to be emitted for the middle  
mouse button, too. Could anyone commit the attached patch? Sorry for the  
inconvenience.

Regards,
Stefan

-- 
Stefan Nikolaus
["ToggleRadioFix.patch" (ToggleRadioFix.patch)]

Index: ktoolbarbutton.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/ktoolbarbutton.cpp,v
retrieving revision 1.83
diff -U3 -r1.83 ktoolbarbutton.cpp
--- ktoolbarbutton.cpp	3 Jan 2005 15:05:54 -0000	1.83
+++ ktoolbarbutton.cpp	3 Jan 2005 17:32:49 -0000
@@ -457,14 +457,15 @@
 
 void KToolBarButton::mouseReleaseEvent( QMouseEvent * e )
 {
+  Qt::ButtonState state = Qt::ButtonState(e->button() | (e->state() & KeyButtonMask));
   if ( e->button() == MidButton )
   {
     QMouseEvent ev( QEvent::MouseButtonRelease, e->pos(), e->globalPos(), LeftButton, e->state() );
     QToolButton::mouseReleaseEvent(&ev);
+    emit buttonClicked( d->m_id, state );
     return;
   }
   QToolButton::mouseReleaseEvent(e);
-  Qt::ButtonState state = Qt::ButtonState(e->button() | (e->state() & KeyButtonMask));
   emit buttonClicked( d->m_id, state );
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]