[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdepim buffers patch
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-01-03 17:06:49
Message-ID: 200501031806.54550.groot () kde ! org
[Download RAW message or body]


On Friday 31 December 2004 21:44, Steve G wrote:
> I was using Korganizer to look at an .ics file and it crashed. I
> investigated the problem and found that a buffer was not big enough to hold
> the text being created via sprintf. The fact that sprintf was being used
> and not snprintf caused a great deal of concern since kdepim handles files
> from untrusted sources.

The libical/ and versit/ fixes have been applied now, along with the fix to 
kholidays. Lots of stuff has moved around, so your patch didn't apply 
straightforawrdly.

Then there's all the gpgme patches in there, which you didn't comment on and 
which I'm not going to commit (not my turf and more pointedly, turf with real 
security implications that I don't want to think about).


-- 
Don't worry, 't ain't no shame to be stupid - ol' mouse.
    GPG: FEA2 A3FE Adriaan de Groot

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]