[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] More missing $(all_libraries)
From:       Szombathelyi György <gyurco () freemail ! hu>
Date:       2004-11-15 10:28:26
Message-ID: 419884CA.9040108 () freemail ! hu
[Download RAW message or body]

Stephan Kulow wrote:
> On Sunday 14 November 2004 18:43, Szombathelyi Gy�rgy wrote:
> 
>>Hello!
>>
>>The attached patches adds missing $(all_libraries) to Makefile ams in
>>various modules. This allows to fully exploit the --as-needed linker flag.
>>Any objections against applying?
>>
> 
> From your arts patch (didn't look deeper):
> -       $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS)
> +       $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS) 
> $(all_libraries)
> 
> I have no idea what the KDE_MT_LDFLAGS is supposed to do, but what you do
> makes this whole setup pointless. When there is already QT_LDFLAGS you're 
> duplicating it with adding all_libraries.
> 
Ok, I'll correct the arts patch, but now the -fvisibility prevents it 
from compiling :(.
Btw, another flag I encountered is KDE_LDFLAGS (in 
kdemultimedia/akode/arts_plugin), which has similar functionality like 
KDE_MT_LDFLAGS.

> Greetings, Stephan
> 
Bye,
György
[prev in list] [next in list] [prev in thread] [next in thread]