[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] More missing $(all_libraries)
From:       Stephan Kulow <coolo () kde ! org>
Date:       2004-11-15 9:32:33
Message-ID: 200411151032.38760.coolo () kde ! org
[Download RAW message or body]


On Sunday 14 November 2004 18:43, Szombathelyi Gy�rgy wrote:
> Hello!
>
> The attached patches adds missing $(all_libraries) to Makefile ams in
> various modules. This allows to fully exploit the --as-needed linker flag.
> Any objections against applying?
>
From your arts patch (didn't look deeper):
-       $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS)
+       $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS) 
$(all_libraries)

I have no idea what the KDE_MT_LDFLAGS is supposed to do, but what you do
makes this whole setup pointless. When there is already QT_LDFLAGS you're 
duplicating it with adding all_libraries.

Greetings, Stephan

-- 
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Py'guapy 평화

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]