[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Small patch to kprogress.cpp
From:       Michael Ritzert <kde () ritzert ! de>
Date:       2004-06-25 17:11:19
Message-ID: 20040625171119.GA1307 () post ! strato ! de
[Download RAW message or body]

On Sun, Jun 20, 2004 at 04:42:23PM +0200, Helge Deller wrote:
> On Sunday 20 June 2004 14:25, Michael Ritzert wrote:
> > I think this somehow slipped in when the other non-const methods were
> > marked deprecated. Without this function using KProgressDialog would not
> > be possible. It also isn't marked for removal in kprogress.h.
> > 
> > Index: kprogress.cpp
> > ===================================================================
> > RCS file: /home/kde/kdelibs/kdeui/kprogress.cpp,v
> > retrieving revision 1.51
> > diff -u -p -r1.51 kprogress.cpp
> > --- kprogress.cpp       30 Jan 2004 10:34:34 -0000      1.51
> > +++ kprogress.cpp       20 Jun 2004 12:21:20 -0000
> > @@ -274,7 +274,6 @@ bool KProgressDialog::allowCancel() cons
> > return mAllowCancel;
> > }
> > 
> > -// ### KDE 4 remove
> > KProgress* KProgressDialog::progressBar()
> > {
> > return mProgressBar;
> > 
> > Can I commit?
> 
> I'm for it !
> This function can not be removed in KDE4, since then it's nearly impossible to use \
> KProgressDialog without it.

Since I received no further comments, I just commited this patch as
pretty obvious.

Michael


[prev in list] [next in list] [prev in thread] [next in thread]