[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Small patch to kprogress.cpp
From:       Helge Deller <deller () gmx ! de>
Date:       2004-06-20 14:42:23
Message-ID: 200406201642.23494.deller () gmx ! de
[Download RAW message or body]

On Sunday 20 June 2004 14:25, Michael Ritzert wrote:
> I think this somehow slipped in when the other non-const methods were
> marked deprecated. Without this function using KProgressDialog would not
> be possible. It also isn't marked for removal in kprogress.h.
> 
> Index: kprogress.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/kdeui/kprogress.cpp,v
> retrieving revision 1.51
> diff -u -p -r1.51 kprogress.cpp
> --- kprogress.cpp       30 Jan 2004 10:34:34 -0000      1.51
> +++ kprogress.cpp       20 Jun 2004 12:21:20 -0000
> @@ -274,7 +274,6 @@ bool KProgressDialog::allowCancel() cons
> return mAllowCancel;
> }
> 
> -// ### KDE 4 remove
> KProgress* KProgressDialog::progressBar()
> {
> return mProgressBar;
> 
> Can I commit?

I'm for it !
This function can not be removed in KDE4, since then it's nearly impossible to use \
KProgressDialog without it. Instead the "const" variant of this function should be \
marked "deprecated"...

BTW, I used KProgressDialog in my latest changes in the Kaddressbook Gnokii \
import/export filter and IMHO KProgressDialog is really bad. It does not handle \
resizing correctly, using setMinimumSize() has no effect and for most other things \
you need to do most parts yourself by hand. IMHO KProgressDialog should be made much \
more developer-friendly....

Helge


[prev in list] [next in list] [prev in thread] [next in thread]