[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdemultimedia (setCheckedState)
From:       David Faure <faure () kde ! org>
Date:       2004-05-19 16:57:34
Message-ID: 200405191857.34207.faure () kde ! org
[Download RAW message or body]

On Wednesday 19 May 2004 14:10, Waldo Bastian wrote:
> I agree that for the toolbars this "Hide / Show" looks very untidy in the
> toolbars submenu. However I consider the "Hide menubar" / "Show menubar" menu
> a big improvement over the version with a checkbox, likewise for the
> fullscreen action.
Yes - that's because they have icons, whereas the toolbar actions don't.

> With checkboxes in the toolbars submenu you get the status of all the toolbars
> in one glance and, especially with many toolbars, it becomes easy to turn one
> particular toolbar on and off because you can use the pattern of the other
> checks as reference
Why not, especially if combining it with Harri's suggestion too (removing "Show"),
which solves the "I click on Show in order to hide it" problem.

Sounds like a solution then...

Hmm, there's a special case when there's only one toolbar, there's no submenu then,
so a menu item called simply Settings / "Toolbar" would be weird. Can we keep the
show/hide for that one, for consistency with the other items at the same level in
the menu (Show/Hide MenuBar, etc.)?

--- ktoolbarhandler.cpp 9 Feb 2004 12:58:07 -0000       1.5
+++ ktoolbarhandler.cpp 19 May 2004 16:56:19 -0000
@@ -105,10 +105,9 @@ namespace
         {
             KToggleToolBarAction *action = new KToggleToolBarAction(
                 toolBar,
-                i18n( "Show %1" ).arg( toolBar->label() ),
+                toolBar->label(),
                 m_actionCollection,
                 toolBar->name() );
-            action->setCheckedState( i18n( "Hide %1" ).arg( toolBar->label() ) );
             // ## tooltips, whatsthis?
             m_toolBarActions.append( action );
         }

--
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]