[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Bug 73440: Konq deletes files when dragging
From:       David Faure <faure () kde ! org>
Date:       2004-03-07 21:52:51
Message-ID: 200403072252.51945.faure () kde ! org
[Download RAW message or body]

On Wednesday 03 March 2004 03:18, Dawit A. wrote:
> I have no idea if your problem is related to this patch either. However,
> this is David's call :)

I think there is some confusion here.
Overwriting a file by dropping another file on top of it in Konqueror,
and writing to a file from within an application, are two very different things.

While I believe the first one should not follow symlinks (see the initial part
of the thread), the second one should obviously follow symlinks!!
If it doesn't do that anymore, then it's a regression introduced by the fix
for the first case. This means Dawit's fix needs work....

> I have posted the patch to fix the problem another way 
> if necessary. See here: http://lists.kde.org/?t=107679141300008&r=1&w=2
The check on linkDest pointing to the file itself looks good to me.
This should be committed IMHO, and although it fixes 73440, it doesn't
change the fact that IMHO dropping a file onto a symlink shouldn't
update the symlink's target. But if fixing this in KIO is too low-level
(and breaks saving to a symlink from other apps) then I guess the fix should
be done in libkonq (KonqOperations?).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]