[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Bug 73440: Konq deletes files when dragging
From:       Andras Mantia <amantia () freemail ! hu>
Date:       2004-03-03 9:51:57
Message-ID: 200403031151.57600.amantia () freemail ! hu
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 03 March 2004 04:18, Dawit A. wrote:
> I have no idea if your problem is related to this patch either. However,
> this is David's call :) I have posted the patch to fix the problem another
> way if necessary. See here: http://lists.kde.org/?t=107679141300008&r=1&w=2

I believe the patch was the one which introduced this behavior with the lines:
+        if( _overwrite && S_ISLNK( buff_orig.st_mode ) )
+          remove( _dest_orig.data() );
        
and
+        if (_overwrite && S_ISLNK(buff_dest.st_mode))
+        {
+            kdDebug(7101) << "copy(): LINK DESTINATION" << endl;
+            remove( _dest.data() );
+        }

If your second patch fixes the original bug, I'd say use that one, as the 
current behavior can be considered as broken (compared to other tools).

Andras

- -- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFARaq9TQdfac6L/08RAsS9AJ9V5NEF5dlffzu4Tr6pYhCM9AbAiACgyN9W
0aGBvK35KpMy0YnXip5DX/0=
=a/Fa
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]