[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Support in KToggleAction for toggling the text itself
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2004-02-06 18:17:19
Message-ID: 200402061917.24827.ogoffart () tiscalinet ! be
[Download RAW message or body]


Le Vendredi 6 Février 2004 18:05, David Faure a écrit :
> OK to commit?

I just looked the patch...
I'm maybe wrong, but i get some thought.
Shouldn't setCheckedText call something like updateText()
And if for a reason or another setText is called while the action is checked, 
the new text will be placed in place of the checked one.

Now, you could argue that setText and setCheckedText shouldn't be called after 
the creation of the action.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]