From kde-core-devel  Fri Feb 06 18:17:19 2004
From: Olivier Goffart <ogoffart () tiscalinet ! be>
Date: Fri, 06 Feb 2004 18:17:19 +0000
To: kde-core-devel
Subject: Re: Support in KToggleAction for toggling the text itself
Message-Id: <200402061917.24827.ogoffart () tiscalinet ! be>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=107609142919653
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-02=_0o9IAAJWUtr3pTo"

--Boundary-02=_0o9IAAJWUtr3pTo
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Le Vendredi 6 F=E9vrier 2004 18:05, David Faure a =E9crit :
> OK to commit?

I just looked the patch...
I'm maybe wrong, but i get some thought.
Shouldn't setCheckedText call something like updateText()
And if for a reason or another setText is called while the action is checke=
d,=20
the new text will be placed in place of the checked one.

Now, you could argue that setText and setCheckedText shouldn't be called af=
ter=20
the creation of the action.

--Boundary-02=_0o9IAAJWUtr3pTo
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAI9o0z58lY8jWrL0RAh0MAKCLGjg0inwvjAxsRan0rLlLZ2eNSACfSkVE
GyE0hn9mBB4edb+umao3rhU=
=1GXk
-----END PGP SIGNATURE-----

--Boundary-02=_0o9IAAJWUtr3pTo--