[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: kwallet lockup (#65978/#71048)
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2004-01-14 12:52:50
Message-ID: 200401141352.50799.l.lunak () suse ! cz
[Download RAW message or body]

On Wednesday 14 of January 2004 13:35, George Staikos wrote:
> On Wednesday 14 January 2004 07:12, Lubos Lunak wrote:
> > >  I think making the kwallet call blocking and closing all popups before
> > > it is a sufficient solution for 3.2. Ok, not updating the GUI may be
> > > significant, but the world will not tumble down. All other solutions I
> > > see are either worse, or need to be post-3.2 (be it making TT create
> > > some proper
> > > qApp->eventLoop()->processEvent( OnlyUpdateGUI ) or whatever).
> >
> >  Please review the attached patch. It reverts back to r1.42 (blocking
> > DCOP call), and closes all open popups in the application before the
> > call.
>
>    This seems like a hack, and I'm wondering what the point is in keeping
> this call around at all if it's going to block GUI updates.  We will have
> to reopen the bug reports that this closed in the first place (read: we're
> playing bug ping-pong here).

 Yes, it's a hack. I'm not opposed to trying some proper processEvents() that 
filters out all potentially dangerous stuff. But right now there's nothing 
like that available, and I consider blocked GUI updates better than KDE3.2 
blocked as a whole. #65978 has 5 duplicates by now (and yes, it shouldn't be 
marked as fixed yet).

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
[prev in list] [next in list] [prev in thread] [next in thread]