[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Make KListView honor renameability
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-12-19 8:11:07
[Download RAW message or body]

On Friday 19 December 2003 01:29, Ravi wrote:
> Hi,
>   The following patch makes KListView honor QListViewItem::setRenameEnabled(). 

This setting defaults to false, right? I can't find it in the docu (grmmbl)
but the code seems to initialize it to false. In that case, I strongly object,
this is going to break existing code.

It's quite scary indeed - there's a global setItemsRenameable and a setRenameable per column
(in KListView), and a setRenameEnabled per column per item (QListViewItem).
But QListView doesn't appear to have global settings, only per item settings,
that's where their model differs.
I don't see how this can be cleaned up in a BIC way before KDE 4.

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]