From kde-core-devel Fri Dec 19 08:11:07 2003 From: David Faure Date: Fri, 19 Dec 2003 08:11:07 +0000 To: kde-core-devel Subject: Re: [PATCH] Make KListView honor renameability X-MARC-Message: https://marc.info/?l=kde-core-devel&m=107182155327988 On Friday 19 December 2003 01:29, Ravi wrote: > Hi, > The following patch makes KListView honor QListViewItem::setRenameEnabled(). This setting defaults to false, right? I can't find it in the docu (grmmbl) but the code seems to initialize it to false. In that case, I strongly object, this is going to break existing code. It's quite scary indeed - there's a global setItemsRenameable and a setRenameable per column (in KListView), and a setRenameEnabled per column per item (QListViewItem). But QListView doesn't appear to have global settings, only per item settings, that's where their model differs. I don't see how this can be cleaned up in a BIC way before KDE 4. -- David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se Qt/KDE/KOffice developer Klarälvdalens Datakonsult AB, Platform-independent software solutions