[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Joseph Wenninger <jowenn () kde ! org>
Date:       2003-09-25 16:20:59
[Download RAW message or body]

Hi

Am Don, 2003-09-25 um 16.24 schrieb Carsten Pfeiffer:
...
> 
> I think the methodnames getOpenFileNamesAndEncoding() etc. are a good sign 
> that they should be in a class KEncodingFileDialog or, if you prefer it, in a 
> nested class KFileDialog::EncodingDialog.

I have chosen the names only to avoid ambiguity problems because of the
default arguments, but if you think it should go into another class, I'm
okay with it. I would choose KEncodingFileDialog. Are there any other
opinions, how the class should be named, of if nesting is better ? If we
have a decission I'll implement it and commit it.

Thinking about statics, I still would have to use function names
different from the ones in KFileDialog, if I inherit KFileDialog, don't
I?

Kind regards
Joseph Wenninger

[prev in list] [next in list] [prev in thread] [next in thread]