[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] Encoding box in the file dialog
From: Andras Mantia <amantia () kde ! org>
Date: 2003-09-25 15:54:48
[Download RAW message or body]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thursday 25 September 2003 17:24, Carsten Pfeiffer wrote:
> Am Donnerstag, 25. September 2003 14:53 schrieb Joseph Wenninger:
>
> Hi,
>
> > I enclose a patch, which adds some additional static methods to the
> > kfiledialog to make the encoding selection more usable, without the need
> > of inheritance or #define protectd/private public
> >
> > The code is not really tested it, I just would like to know, if
> > something like my patch would be accepted, before I put further work
> > into it
>
> I think the methodnames getOpenFileNamesAndEncoding() etc. are a good sign
> that they should be in a class KEncodingFileDialog or, if you prefer it, in
a
> nested class KFileDialog::EncodingDialog.
With so much new static methods this may make sense. Joseph, if you can do,
I'm OK also with a new class.
Andras
>
> Cheers
> Carsten
>
>
>
>
>
>
>
- --
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
iD8DBQE/cw/ITQdfac6L/08RAny5AJ9uFDopeN4Xt2wYKgFLUStmAb+aeACgkq/2
QF41MbzZcDQYKo1Kcv6AjwQ=
=wphy
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic