[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Carsten Pfeiffer <carpdjih () mailbox ! zrz ! tu-berlin ! de>
Date:       2003-09-25 1:01:09
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Tuesday 23 September 2003 23:24, Andras Mantia wrote:

> If you insist to move it in a new file/class, I can do it. Of course, that
> would be easier from the beginning, as basicly Kate::FileDialog was an
> extension of the KFileDialog, just that it was in kdebase instead of
> kdelibs. But I really think that this belongs to the KFileDialog class, but
> of course you are the maintainer and you decide what to do with it. And

Well, I for one consider KFD already quite huge. And if there is a method that 
is only useful when a specific c'tor is used, then one should consider moving 
that feature into another class.

> sorry for committing without waiting for your answer, as I already talked
> with you about this issue before and I wrote another mail a week ago -
> without a patch though - about merging and I thought everything's OK with
> the patch.

No worries, I'm having little time these days and can't follow the lists as 
I'd like to, so I won't complain about someone not waiting for my answer.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBP3I+VaWgYMJuwmZtAQECHQf/eQdrC45S2Vc/h/BJXSMe+gT0tY9JeQIp
btdiIBoV/p72Q4TkI/e+Z7FYb0UcgOapS7DpTxb8R3t1OqBvcs+whutnc5xXvGK1
+iJS5oqlz+lHlsC04ZYYvQYaS+ow3QuV4N8LmrnLs8ghYXQfuEz3pCZVHDkYXxxt
V8SjxKQXnvpYKz4UBLTwvpuzud8+bBgPekcO0or7OJsC2eFpXXgCyNT0GQQCbSQu
XmwlMDdTE/a579FtGq2gU9yGSsZpPx1R3mHY3MPUOx96x3svbyTN+TJAkOH2aUA/
HOQVRTqKaviHp4w/txnbwm0RisoiOZ4oibJ0jK1HVWlNV9kgio8ZRg==
=78pJ
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]