[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Encoding box in the file dialog
From:       Carsten Pfeiffer <carpdjih () mailbox ! zrz ! tu-berlin ! de>
Date:       2003-09-25 0:27:45
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Wednesday 24 September 2003 10:46, Ingo Klöcker wrote:

> KTextFileDialog is a bad name for this class. If the user wants to
> attach a file in KMail, then KMail can't forsee whether this will be a
> text file or a binary file. For text files we need the encoding (cf.
> http://bugs.kde.org/show_bug.cgi?id=64815). So we would always have to

But this is confusing for all other types of files, then. The encoding
selection box should be disabled when a non text/* file is selected. Also you
can select multiple files in the attachments filedialog...

I think it's better to let the user choose the attachments freely and show a
messagebox if he selected textfiles to make him consider changing their
encoding. The encoding-entry in the attachments-listview could have an
exclamation mark when an encoding was automatically chosen for a text-file.

> use this subclass for the attachment file dialog. The suggested class
> name would be confusing (for me as developer) since it suggests that it
> can only deal with text files. I suggest to call it KExtendedFileDialog
> (in case it's really necessary to put this in a subclass).

Well, "Extended" is rather meaningless and doesn't tell anything about the
purpose. "Text" was only a proposal tho, I welcome other ideas.

Cheers
Carsten Pfeiffer


-----BEGIN PGP SIGNATURE-----

iQEVAwUBP3I2gaWgYMJuwmZtAQF1VAf/SJ8TxQ2pw8iVqMq7mOFLeap1XHJxa54D
YlgMdm/Pwa39AUIWSPVgII5gfpQ77uIkD/fZm3cVt414JtllCAwMUshvQ/z6WxLr
0Hho08s61HY1IC3iHv+ouTaZ1lLVBNaLtf8kRsWPJeCfij11kAcL2HdyPUtKSo9p
VWqxex5Mwdu3AKLZTHSnTHg/TS93V2lzbf44ad62RA9oFrITI4bDeps3Hct3mCZS
wJhK36wHg0S63sXw46MSKBXEXk5qbD/lDnbfb3j7dZlLRzQGu0+2XqWktZOOyb6R
FRWGPVIlzM3rQKNarXr/m9yXpWhLMGwQne6DO9NO8lJhN7F3A73aHw==
=WMT4
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]