[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KConfig sync speedup patch rev 1
From:       Waldo Bastian <bastian () kde ! org>
Date:       2003-09-09 19:44:57
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 09 September 2003 15:09, Ian Reinhart Geiser wrote:
> Hi,
> 	At n7y I worked out this patch with the help of david.  It seems to speed
> up some apps when i measure them with calltree.  The issue was that before
> this patch every time you call sync the config file is reparsed.  This
> patch causes the config file not to be reparsed unless it has changed on
> disk since the last write.
>
> 	In kmail with calltree without it I seem to see 10% of startup time spent
> in KConfigINIBackend::sync(), where as after the patch it only spends about
> 7%....  Im still not sure if these numbers are accurate, so im hopeful
> others can test, modify this patch.

I have committed a slightly modified version of your patch. If kmail spends so 
much time in sync() though it probably means that sync() gets called way too 
often in the first place.

Cheers,
Waldo
- -- 
bastian@kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/Xi25N4pvrENfboIRAviYAJ0WoBDbuz71qbl/IKpRomGb37tFEQCfQm7+
4dDtcxWsruyCQdlYl5XoP/A=
=Sb7D
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]