[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: KGlobalAccel + Tux keys
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2002-10-31 8:48:35
[Download RAW message or body]

On Wednesday 30 October 2002 22:00, Ellis Whitehead wrote:
> On Wednesday 30 October 2002 11:41, Lubos Lunak wrote:
> >  Hello,
> >
> >  please review. When configuring global shortcuts for e.g. KMixApplet or
> > KNotes, it's not possible to create shortcuts with the Tux modifier key
> > (called by the strange name 'Win' in KKeyDialog for some unknown reason).
>
> Win = Window Manager

 Interesting interpretation.

> It doesn't make any sense to call it the Tux key.  No one calls it the Mac
> key or the MS key, nor do the *BSD people call it the BSD key. *grin*

 I was just joking (but in fact, I'd actually expect the key to be called 
Meta).

>
> > This is because such shortcuts are allowed only for KGlobalAccel, and
> > KKeyDialog::configure( KGlobalAccel*, ... ) creates the KKeyChooser as
> > when configuring app shortcuts.
>
> Looks good.  Would you mind making the new constructor private, though?  I
> dislike the extremely messy KKeyChooser stuff getting more public methods
> to work around in the future.
>

 Done.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
[prev in list] [next in list] [prev in thread] [next in thread]