[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: KGlobalAccel + Tux keys
From:       Ellis Whitehead <ellis () kde ! org>
Date:       2002-10-30 20:56:16
[Download RAW message or body]

On Wednesday 30 October 2002 11:41, Lubos Lunak wrote:
>  Hello,
>
>  please review. When configuring global shortcuts for e.g. KMixApplet or
> KNotes, it's not possible to create shortcuts with the Tux modifier key
> (called by the strange name 'Win' in KKeyDialog for some unknown reason).

Win = Window Manager
It doesn't make any sense to call it the Tux key.  No one calls it the Mac key 
or the MS key, nor do the *BSD people call it the BSD key. *grin*

> This is because such shortcuts are allowed only for KGlobalAccel, and
> KKeyDialog::configure( KGlobalAccel*, ... ) creates the KKeyChooser as when
> configuring app shortcuts.

Looks good.  Would you mind making the new constructor private, though?  I 
dislike the extremely messy KKeyChooser stuff getting more public methods to 
work around in the future.

Cheers,
Ellis

[prev in list] [next in list] [prev in thread] [next in thread]