[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Screenshot [Was [PATCH] Distinguish Read-Only KLineEdit from Read-Write one...]
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2002-03-21 19:41:16
[Download RAW message or body]

On Thursday 21 March 2002 19:24, Dawit Alemayehu wrote:
> Hi,
>
> David was nice enough to post the screen shot of the read-only lineedit
> with my patch.  Have a look here:
>
> http://people.mandrakesoft.com/~david/readonlyle.png
>
> and compare that with what you currently have "ALT+F2 -> kcmshell cookies".

I like your change and for read only line edits I think you should indeed 
commit.

BUT: Your example (kcmshell cookies) is a perfect place where I _don't_ want 
to see this. A readonly lineedit IMNSHO is a line edit that is readonly due 
to external constraints, like missing permissions or so.

I think you should never ever abuse a line edit to represent a label, i.e. to 
show a text that cannot possibly be edited by the user anyway. In the 
messageboxes you can now select text, so whatever class is used there, that 
one is the way to go if you ask me.

Martijn
[prev in list] [next in list] [prev in thread] [next in thread]