[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KNewsTicker
From:       Lars Knoll <lars () trolltech ! com>
Date:       2002-03-12 9:14:36
[Download RAW message or body]


> On March 11, 2002 07:26, Frerich Raabe wrote:
> > Hi,
> >
> > I've attached three patches for KNewsTicker.
>
> ...
>
> > These two patches (well, actually only the first
> > The third patch is in xmlnewsaccess.diff - it makes KNewsTicker parse
> > even slightly invalid XML files (Those which start with whitespace
> > instead of '<?xml'). The patch was apparently written by Lars and sent to
> > me by Volker.
>
> Instead of the:
> (*charData == ' ' || *charData == '\n' || *charData == '\t' || *charData ==
> '\r') )
>
> I'd look in to using QChar::isSpace(), as it handles all the characters you
> check for, plus two you missed (characters 11 and 12).

You could if charData was a pointer to a QChar and not a char.

Lars

[prev in list] [next in list] [prev in thread] [next in thread]