[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] fixes Bug #39203
From:       Matthias Welwarsky <matze () stud ! fbi ! fh-darmstadt ! de>
Date:       2002-03-12 8:03:12
[Download RAW message or body]

On Tuesday 12 March 2002 00:07, John Firebaugh wrote:
> On Monday 11 March 2002 1:08, Matthias Welwarsky wrote:
> > Hi,
> >
> > attached patch fixes a kicker crash induced by the ksysguard applet. The
> > bugreport at bugs.kde.org contains a patch, too, but I'm not sure if it
> > has side effects.
> >
> > At least I understand my version ;)
> > OK to commit?
>
> What is the effect of not calling SensorMgr->unlinkClient() when the applet
> shuts down?

Hm, unlinkClient() calls SensorAgent->unlinkClient() for all existing 
SensorAgents. Within SensorAgent::unlinkClient() all references to the given 
Client are cleared from queued SensorRequests. But as the destructor of 
KSysguardApplet is called only when the applet is closed, all SensorAgents 
will die anyway, and so will the queued sensor requests.

Will SensorMgr->deleteLater() definitely destroy the object later, even if the 
applet has died? If not, will it introduce a memory leak if the applet was 
loaded internally?

regards,
	Matze

[prev in list] [next in list] [prev in thread] [next in thread]