[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Multiple backends for libkabc
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2002-03-05 16:25:15
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Cornelius Schumacher wrote:

> The attached patch adds the option to libkabc to attach different
> backends, e.g. a SQL database or a LDAP directory. The patch moves
> dependencies on the file backend behind an additional layer of 
> Resource
> classes. There is an example class ResourceSql, which accesses data 
> from
> an SQL database. It's not really useful at the moment, but it serves 
> as a
> second case for testing the design.
> 
> It would be good to add the patch before the 3.0 release, because
> otherwise we wouldn't be able to add it before the next binary
> incompatible release.
> 
> Comments?

Please add a check for QT_NO_SQL. Else you get the following compile 
errors if you try to compile kdelibs/kabc with Qt compiled with 
- -disable-sql (wasn't this switch listed in README.qt-copy not too long 
ago?).

../../../kdelibs/kabc/resourcesql.cpp: In method `bool 
KABC::ResourceSql::open()':
../../../kdelibs/kabc/resourcesql.cpp:18: no method 
`QSqlDatabase::drivers'
../../../kdelibs/kabc/resourcesql.cpp:23: no method 
`QSqlDatabase::addDatabase'
../../../kdelibs/kabc/resourcesql.cpp:30: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp:31: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp:32: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp:33: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp:35: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp: In method `void 
KABC::ResourceSql::close()':
../../../kdelibs/kabc/resourcesql.cpp:45: invalid use of undefined type 
`class QSqlDatabase'
../../../kdelibs/kabc/resourcesql.h:7: forward declaration of `class 
QSqlDatabase'
../../../kdelibs/kabc/resourcesql.cpp: In method `bool 
KABC::ResourceSql::load(KABC::AddressBook *)':
../../../kdelibs/kabc/resourcesql.cpp:50: `QSqlCursor' undeclared 
(first use this function)
../../../kdelibs/kabc/resourcesql.cpp:50: (Each undeclared identifier 
is reported only once
../../../kdelibs/kabc/resourcesql.cpp:50: for each function it appears 
in.)
../../../kdelibs/kabc/resourcesql.cpp:50: parse error before `('
../../../kdelibs/kabc/resourcesql.cpp:51: `cur' undeclared (first use 
this function)
../../../kdelibs/kabc/resourcesql.cpp:56: `QSqlQuery' undeclared (first 
use this function)
../../../kdelibs/kabc/resourcesql.cpp:56: parse error before `('
../../../kdelibs/kabc/resourcesql.cpp:57: `query' undeclared (first use 
this function)
../../../kdelibs/kabc/resourcesql.cpp:64: parse error before `('
../../../kdelibs/kabc/resourcesql.cpp:65: `entryQuery' undeclared 
(first use this function)
make[3]: *** [resourcesql.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive-am] Error 2

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8hPFrqUQWN/hplRsRAsXyAKDTbH7SK05GlMIIeqsddT6hO0nV4QCgylvl
zeROLvLs6lGr0cTfA36sP0Q=
=IMR5
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]