[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ksmserver: take two
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-02-02 20:03:28
[Download RAW message or body]

On Wednesday 30 January 2002 23:00, ossi@master.kde.org wrote:
> dfaure: you introduced the keyevent handler - what was the idea behind it?
To abort the shutdown when pressing Esc, as the kdDebug said ;)

>  qdialog handles escape for us, doesn't it?

Well, yes, but the dialog is only there to ask for confirmation.
When there is no dialog, or after saying ok in the dialog, it should still be 
possible to abort the shutdown - this was particularly useful at the time 
when it was common that some applications wouldn't react properly, and would 
lock the shutdown process.
Ok, due to the "can't leave the gray widget during the shutdown process" 
change (see line 1056), the gray widget gets destroyed very early, so the Esc 
functionality wouldn't work..... Unless a good fix for the 
application-interaction issue is found, I suggest to add the code for 
handling Esc to ksmserver itself (instead of the gray widget), maybe as a 
KGlobalAccel created at the beginning of the shutdown process ?

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david, http://www.konqueror.org
KDE 3.0: Konquering the Desktops
[prev in list] [next in list] [prev in thread] [next in thread]