[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    PATCH: make kaccelaction.h noinst_HEADER
From:       Ellis Whitehead <kde () ellisw ! net>
Date:       2002-01-30 3:16:44
[Download RAW message or body]

I want to remove kaccelaction.h (which I first created a couple months ago) 
from public installation for the sake of future flexibility.  No public header
files include it and the only place that it's needed outside of kdecore is in
the kcontrol shortcut module:

$ grep kaccelaction -r kdeaddons kdeartwork kdeedu kdegames kdegraphics kdemultimedia kdenetwork kdepim \
kdesdk kdeutils kdevelop kdevelopHEAD koffice $
$ grep kaccelaction -r kdebase
kdebase/kcontrol/keys/main.cpp:#include <kaccelaction.h>
kdebase/kcontrol/keys/shortcuts.h:#include <kaccelaction.h>

So the commit will also add a copy of kaccelaction.h to kdebase/kcontrol/keys.
This isn't pretty, but it's a lot better than having to write hacks for the 
next few years.

Cheers,
Ellis


Index: Makefile.am
===================================================================
RCS file: /home/kde/kdelibs/kdecore/Makefile.am,v
retrieving revision 1.276
diff -u -3 -d -p -b -B -r1.276 Makefile.am
--- Makefile.am	2002/01/27 14:13:52	1.276
+++ Makefile.am	2002/01/29 19:47:25
@@ -32,7 +32,7 @@ include_HEADERS = kconfig.h kconfigdata.
 	kcharsets.h \
 	kprocess.h kprocctrl.h klocale.h kicontheme.h kiconloader.h kdebug.h \
 	kwinmodule.h kwin.h krootprop.h \
-	kshortcut.h kkeynative.h kaccelaction.h kaccel.h kglobalaccel.h \
+	kshortcut.h kkeynative.h kaccel.h kglobalaccel.h \
 	kstdaccel.h kshortcutlist.h \
 	kcatalogue.h \
 	kregexp.h kcompletion.h kstringhandler.h kstringhandler.h \
@@ -51,7 +51,7 @@ include_HEADERS = kconfig.h kconfigdata.
 libkdefakes_la_SOURCES = fakes.c vsnprintf.c
 libkdefakes_la_LDFLAGS = -version-info 4:0

-noinst_HEADERS = kaccelbase.h kaccelprivate.h kckey.h kcompletion_private.h \
+noinst_HEADERS = kaccelaction.h kaccelbase.h kaccelprivate.h kckey.h kcompletion_private.h \
 	kextsocklookup.h kglobalaccel_x11.h kkeyserver_x11.h \
 	kregpriv.h ksycocadict.h ksycocafactory.h netsupp.h


[prev in list] [next in list] [prev in thread] [next in thread]